[PATCH] D119006: [AMDGPU] SILoadStoreOptimizer: avoid unbounded register pressure increases

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 11:13:08 PST 2022


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:604-605
+    return false;
+  // TODO: Use LaneMasks for virtregs to allow non-conflicting subreg uses/defs.
+  // FIXME: Use RegUnits for physreg operands to detect partial overlaps.
+  for (const auto &BOp : B.operands()) {
----------------
Generally those don't exist at this point outside of copies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119006/new/

https://reviews.llvm.org/D119006



More information about the llvm-commits mailing list