[PATCH] D119075: [DAGCombine][ARM] Custom lower smaller-than-legal MULH/AVG/ABD

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 00:34:19 PST 2022


dmgreen added a comment.

In D119075#3299246 <https://reviews.llvm.org/D119075#3299246>, @RKSimon wrote:

> Why not handle this generically - accept AVG patterns of any type pre-legalization and expand back during legalization if necessary?

Hmm. Won't that be quite inefficient? Creating nodes for architectures that don't even expect to use them? A mulh for example - I wouldn't expect the generic DAG combiner to create i8 mulh on Arm targets - it's not something it will ever need, and I feel it would just get in the way of the optimisations it is trying to make.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119075/new/

https://reviews.llvm.org/D119075



More information about the llvm-commits mailing list