[PATCH] D118415: AMDGPU: Reserve v32 if we may need to copy between AGPRs on gfx908

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:603
     }
+  } else if (ST.hasMAIInsts() & MFI->usesAGPRs(MF)) {
+    // In order to guarantee copying between AGPRs, we need a scratch VGPR
----------------
rampitec wrote:
> rampitec wrote:
> > Still "&& !ST.hasGFX90AInsts()".
> > Use logical and.
> Still need !ST.hasGFX90AInsts().
hasGFX90AInsts is the if preceding this else if so that doesn't reach here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118415/new/

https://reviews.llvm.org/D118415