[PATCH] D118694: [Bitcode] Add partial support for opaque pointer auto-upgrade

Sun Feb 6 13:46:21 PST 2022

nikic added a comment.

In D118694#3299435 <https://reviews.llvm.org/D118694#3299435>, @dblaikie wrote:

> In D118694#3298975 <https://reviews.llvm.org/D118694#3298975>, @aprantl wrote:
>
>> For a one-off test checking in a manually crafted .bc file seems fine to me. If you are planning to add more tests, we should invest in some kind of yaml2bc utility (like yaml2obj). Not sure if this answers your question?
>
> Yeah, was mostly asking how firm we are about constructing those sort of test cases. Seems not every existing error is covered - so I don't want to request undue work/unreasonable standard for new work like this - but testing error paths does seem important to me.
>
> @nikic could you add hand-crafted bitcode test coverage for these error messages/paths?

Sorry, I don't think that would be a good use of my time. Of course, if you'd like to construct invalid bitcode files yourself, I will not object to their inclusion.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118694/new/

https://reviews.llvm.org/D118694