[PATCH] D118694: [Bitcode] Add partial support for opaque pointer auto-upgrade

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D118694#3298975 <https://reviews.llvm.org/D118694#3298975>, @aprantl wrote:

> For a one-off test checking in a manually crafted .bc file seems fine to me. If you are planning to add more tests, we should invest in some kind of yaml2bc utility (like yaml2obj). Not sure if this answers your question?

Yeah, was mostly asking how firm we are about constructing those sort of test cases. Seems not every existing error is covered - so I don't want to request undue work/unreasonable standard for new work like this - but testing error paths does seem important to me.

@nikic could you add hand-crafted bitcode test coverage for these error messages/paths?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118694/new/

https://reviews.llvm.org/D118694