[PATCH] D118118: [SDAG] Preserve unpredictable metadata, teach X86CmovConversion to respect this metadata

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:113
                                         // this instruction.
+    Unpredictable    = 1 << 16,         // Instruction is unpredictable.
   };
----------------
RKSimon wrote:
> I don't suppose there's any existing MIFlag bits that we can get rid of?
I wondered if we could have separate X86 CMOV opcodes for unpredictable? Since we're only trying to convey information to this one X86 specific pass. But that might require too many updates to the CMOV related functions in X86InstrInfo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118118/new/

https://reviews.llvm.org/D118118