[PATCH] D118118: [SDAG] Preserve unpredictable metadata, teach X86CmovConversion to respect this metadata

Sun Feb 6 11:58:15 PST 2022

xbolva00 added a comment.

In D118118#3299513 <https://reviews.llvm.org/D118118#3299513>, @RKSimon wrote:

> @xbolva00 Are you still working on this atm or are you waiting to see what happens with https://discourse.llvm.org/t/rfc-cmov-vs-branch-optimization/59628 ?

Yes, I am still interested in this patch.

That RFC would benefit from this work as well, especially if they go for midend LLVM IR pass - but I think that pass could be super tricky to do it right and actually do not regress the performance for "important workloads" (I remember some huge regression around LLVM 9 related to cmov vs branch).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118118/new/

https://reviews.llvm.org/D118118