[PATCH] D118754: [DebugInfo] Always emit `.debug_names` with dwarf 5 for Apple platforms

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D118754#3298260 <https://reviews.llvm.org/D118754#3298260>, @JDevlieghere wrote:

> In D118754#3298255 <https://reviews.llvm.org/D118754#3298255>, @JDevlieghere wrote:
>
>> So on an Apple platform, regardless of the dwarf version, if you don't pass pubnames, we set NameTableKind to None in the frontend. If we're compiling with DWARFv4, then we emit the Apple accelerator tables unconditionally, without checking the NameTableKind. If we're compiling with DWARFv5, then in the backend we correctly decide to emit the debug name accelerator tables, but the debug names implementation does check the NameTableKind. It skips every CU that has NameTableKind set to anything different than "Default" and we end up without any accelerator tables at all.
>
> I guess we could say "don't check the name table kind" on Apple platforms, but then we lose the ability to disable accelerator tables at all.

Ah, I thought there was no such ability already? Were you wanting to add such an ability? Maybe good to consider that somewhat orthogonally to the issue of "need some kind of accelerator tables for MacOS in DWARFv5".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118754/new/

https://reviews.llvm.org/D118754