[llvm] 3918dd6 - [mte] fix runOnFunction return value falsely suggesting function was modified.

Florian Mayer via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 4 10:34:22 PST 2022


Author: Florian Mayer
Date: 2022-02-04T10:34:14-08:00
New Revision: 3918dd6b8acf8c5886b9921138312d1c638b2937

URL: https://github.com/llvm/llvm-project/commit/3918dd6b8acf8c5886b9921138312d1c638b2937
DIFF: https://github.com/llvm/llvm-project/commit/3918dd6b8acf8c5886b9921138312d1c638b2937.diff

LOG: [mte] fix runOnFunction return value falsely suggesting function was modified.

If NumInterestingAllocas == 0 we do not add any instrumentation or
padding in the previous loop.

Reviewed By: eugenis

Differential Revision: https://reviews.llvm.org/D118961

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/AArch64StackTagging.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/AArch64StackTagging.cpp b/llvm/lib/Target/AArch64/AArch64StackTagging.cpp
index 5cf484e9fe274..b9452c7bb2b0b 100644
--- a/llvm/lib/Target/AArch64/AArch64StackTagging.cpp
+++ b/llvm/lib/Target/AArch64/AArch64StackTagging.cpp
@@ -605,7 +605,7 @@ bool AArch64StackTagging::runOnFunction(Function &Fn) {
   }
 
   if (NumInterestingAllocas == 0)
-    return true;
+    return false;
 
   std::unique_ptr<DominatorTree> DeleteDT;
   DominatorTree *DT = nullptr;


        


More information about the llvm-commits mailing list