[PATCH] D116743: [PowerPC] Add assembly comments for instructions that use the vector registers.

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 12:35:16 PST 2022


lei added a comment.

> Not a silly question at all!
> Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example `# 8-byte Folded Spill`) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.

Is it possible to append to the comment line instead of adding a new comment line below it?  Not a huge deal but thought maybe it would look cleaner to have all comments on the same line.  Or at least indented to indicate it's part of the previous line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116743/new/

https://reviews.llvm.org/D116743



More information about the llvm-commits mailing list