[PATCH] D118797: [lld-macho][nfc] Eliminate InputSection::Shared

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/InputFiles.h:55
 // from the start of the original pre-split InputSection.
 struct Subsection {
   uint64_t offset = 0;
----------------
int3 wrote:
> oontvoo wrote:
> > what would we call this `Subsection` if InputSection were to be renamed?
> > 
> > 
> `SubsectionEntry` maybe. It is, after all, an entry into an ordered-map-like structure...
Makes sense. I'd support renaming InputSection if you're up to doing it :)

(personally I don't feel strongly that lld-macho *has to* mirror file and type names 100% after elf, but that's just me)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118797/new/

https://reviews.llvm.org/D118797