[PATCH] D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 06:56:44 PST 2022


oontvoo added a comment.

In D116787#3288864 <https://reviews.llvm.org/D116787#3288864>, @MaskRay wrote:

> I agree that extending `--sort-symbols` to `--sort-symbols=<value>` is useful, since people may want to support different ways.
> For example GNU nm has `--numeric-sort`, `--no-sort`, `--size-sort`. This cannot be changed but retrospectively maybe `--sort={numeric,size}` is a better UI.
>
> `--sort-symbols=name --sort-symbols=type` specifying multi sort keys may not be obvious. The most common UI is that the last option overrides previous ones.
> `--sort-symbols=name,type` looks good to me to specify multi sort keys.

Ok, SG!

> Note: it may be worth adding --sort-symbols= to llvm-objdump as well. It's good to spend some time on the design.

Yep, planning on doing that that too. :)

ThankS!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116787/new/

https://reviews.llvm.org/D116787



More information about the llvm-commits mailing list