[PATCH] D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 14:38:10 PST 2022


MaskRay added a comment.

I agree that extending `--sort-symbols` to `--sort-symbols=<value>` is useful, since people may want to support different ways.
For example GNU nm has `--numeric-sort`, `--no-sort`, `--size-sort`. This cannot be changed but retrospectively maybe `--sort={numeric,size}` is a better UI.

`--sort-symbols=name --sort-symbols=type` specifying multi sort keys may not be obvious. The most common UI is that the last options overrides previous ones.
`--sort-symbols=name,type` looks good to me to specify multi sort keys.

(I will add a note that `stabs-sorted.yaml` looks quite long. It'd be wonderful if creating a test has less boilerplate.
Hope someone in #lld-macho <https://reviews.llvm.org/tag/lld-macho/> may consider this as yet another motivation to improve Mach-O yaml2obj...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116787/new/

https://reviews.llvm.org/D116787



More information about the llvm-commits mailing list