[PATCH] D118857: [DWARF][codegen] Fix for Aranges when split inlining is present

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 16:18:05 PST 2022


ayermolo added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2941-2942
   // Filter labels by section.
   for (const SymbolCU &SCU : ArangeLabels) {
+    if (SkeletonCUs.count(SCU.CU))
+      continue;
----------------
dblaikie wrote:
> Should we avoid putting these entries in `ArangeLabels` to begin with, rather than filtering them out here?
I looked at where this is added, and I think it would involve passing a flag through multiple levels of API. I wasn't sure what would be more acceptable. Just cleaning it up here, or doing that. This is more self contained.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118857/new/

https://reviews.llvm.org/D118857



More information about the llvm-commits mailing list