[PATCH] D118857: [DWARF][codegen] Fix for Aranges when split inlining is present

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2941-2942
   // Filter labels by section.
   for (const SymbolCU &SCU : ArangeLabels) {
+    if (SkeletonCUs.count(SCU.CU))
+      continue;
----------------
Should we avoid putting these entries in `ArangeLabels` to begin with, rather than filtering them out here?


================
Comment at: llvm/test/DebugInfo/X86/fission-inline-aranges.ll:11-31
+; struct foo {
+;   template<typename T>
+;   static void f2();
+;   static void f3(...);
+; };
+;
+; void f1();
----------------
Does this need templates, using declarations, and if/scopes, etc? Or could it be simplified a bit? If it can't be, might be worth some explanatory text about why all these features are needed to tickle the bug?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118857/new/

https://reviews.llvm.org/D118857