[PATCH] D118618: [flang] Fix invalid diagnostics in wrapper and reduce code dup.

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

This change makes a lot of sense and is a big improvement.

I just feel that the summary focus on one of the side effects rather than what this patch really does. I think that the main thing here is the refactoring and the code-duplication reduction. The inconsistent diagnostic is also fixed, but that's a relatively small change (hence "side-effect") and could be achieved without the refactoring. So, I would update the summary :) This is not a blocker for me though!



================
Comment at: flang/tools/f18/flang:319
-    then status=$?
-         echo flang: in "$PWD", flang-new failed with exit status $status: "$wd/bin/flang-new" "${opts[@]}" "$@" >&2
-         exit $status
----------------
This seems to be the only place in which the diagnostic is inconsistent with the compiler invocation (should be `$ect_fc` instead of `"$wd/bin/flang-new"`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118618/new/

https://reviews.llvm.org/D118618