[PATCH] D118618: [flang] Fix invalid diagnostics in wrapper and reduce code dup.

[Yury Gribov via Phabricator via llvm-commits]

ygribov added inline comments.


================
Comment at: flang/tools/f18/flang:282
 
+run_checked() {
+  if ! "$@"
----------------
awarzynski wrote:
> It would be great if this name could follow's LLVM's [[ https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly | coding guide ]]:
> 
> > Function names should be verb phrases (as they represent actions), and command-like function should be imperative. The name should be camel case, and start with a lower case letter (e.g. openFile() or isFoo()).
> 
> Perhaps `run_and_check_status`? `run_compiler_command`? `run_and_check`? `run_cmd`?
> 
> Also, could you add a short description?
`run_and_check` sounds fine and indeed I forgot description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118618/new/

https://reviews.llvm.org/D118618