[PATCH] D118529: [ELF] Rename adjustSectionsBeforeSorting to adjustOutputSections and make it affect INSERT commands

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 10:14:53 PST 2022


MaskRay added a comment.

In D118529#3286751 <https://reviews.llvm.org/D118529#3286751>, @peter.smith wrote:

> Thanks for the update. The `adjustOutputSections` still makes me a bit nervous as the name implies "do stuff" without any real idea of what just from the name. One possibility would be to split it into smaller functions, for example: `setAlignment`, `removeFlagsFromEmptySection` `removeDiscardedOutputSections`. Anyhow I don't want to let that get in the way of the actual fix.

Thanks for the review. I acknowledge this. Added the following to the description:

> The new name is not set into stone. The function mixes several tasks and the code may be refactored in a way that we may give them more meaningful names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118529/new/

https://reviews.llvm.org/D118529



More information about the llvm-commits mailing list