[PATCH] D118529: [ELF] Rename adjustSectionsBeforeSorting to adjustOutputSections and make it affect INSERT commands
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 1 01:58:52 PST 2022
peter.smith accepted this revision.
peter.smith added a comment.
Thanks for the update. The `adjustOutputSections` still makes me a bit nervous as the name implies "do stuff" without any real idea of what just from the name. One possibility would be to split it into smaller functions, for example: `setAlignment`, `removeFlagsFromEmptySection` `removeDiscardedOutputSections`. Anyhow I don't want to let that get in the way of the actual fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118529/new/
https://reviews.llvm.org/D118529
More information about the llvm-commits
mailing list