[PATCH] D118695: [flang] Add lowering for basic empty SUBROUTINE

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/lib/Lower/Bridge.cpp:248-252
+      // The current block must end with a terminator.
+      if (blockIsUnterminated())
+        builder->create<mlir::BranchOp>(toLocation(), finalBlock);
+      // Set insertion point to final block.
+      builder->setInsertionPoint(finalBlock, finalBlock->end());
----------------
kiranchandramohan wrote:
> Nit: Are these required for this Patch?
Not necessary right. I'll remove it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118695/new/

https://reviews.llvm.org/D118695