[PATCH] D118695: [flang] Add lowering for basic empty SUBROUTINE

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.

I have added entries to the tracker https://github.com/flang-compiler/f18-llvm-project/projects/6



================
Comment at: flang/lib/Lower/Bridge.cpp:248-252
+      // The current block must end with a terminator.
+      if (blockIsUnterminated())
+        builder->create<mlir::BranchOp>(toLocation(), finalBlock);
+      // Set insertion point to final block.
+      builder->setInsertionPoint(finalBlock, finalBlock->end());
----------------
Nit: Are these required for this Patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118695/new/

https://reviews.llvm.org/D118695