[PATCH] D118644: [x86] invert a vector select IR canonicalization with a binop identity constant

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added a comment.

In D118644#3286836 <https://reviews.llvm.org/D118644#3286836>, @RKSimon wrote:

> If we're targeting the D113442 <https://reviews.llvm.org/D113442> regressions for 14.x I'd probably suggest we just limit this to AVX512 targets as a quick fix and iterate on it for 15.x.

I agree. I didn't restrict it in this first draft just to show that there are likely going to be several subtle opportunities/regressions that need to be dealt with. The blendv codegen with AVX2 is one.

For AVX512, I'm not sure exactly which flavors we want to include/exclude - should I add more/different RUN lines to the test file? Do we want more tests with 512-bit types?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118644/new/

https://reviews.llvm.org/D118644