[PATCH] D118644: [x86] invert a vector select IR canonicalization with a binop identity constant

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:48979
+  // TODO: This (and possibly the entire function) belongs in a
+  //       target-independent location. The cases should also match the IR
+  //       function ConstantExpr::getBinOpIdentity().
----------------
xbolva00 wrote:
> Target independent location with target hook?
Yes, that is the most likely outcome. I think it would be fine to start with just generic opcodes, and then we could extend it with target-specific as needed. That's similar to what we have for TLI.isCommutativeBinop() (used below here).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118644/new/

https://reviews.llvm.org/D118644