[PATCH] D118644: [x86] invert a vector select IR canonicalization with a binop identity constant

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 12:57:15 PST 2022


xbolva00 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:48979
+  // TODO: This (and possibly the entire function) belongs in a
+  //       target-independent location. The cases should also match the IR
+  //       function ConstantExpr::getBinOpIdentity().
----------------
Target independent location with target hook?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118644/new/

https://reviews.llvm.org/D118644



More information about the llvm-commits mailing list