[PATCH] D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

In D96035#3284832 <https://reviews.llvm.org/D96035#3284832>, @dblaikie wrote:

> In D96035#3284247 <https://reviews.llvm.org/D96035#3284247>, @avl wrote:
>
>> rebased.
>> refactored.
>> implemented performance improvements(it is 1.3x slower in single thread mode, 2.4x faster im multi-thread mode).
>
> 1.3x slower means what took 1second before now takes 2.3 seconds?

No, sorry, I meant  what took 1second before now takes 1*1.3 = 1.3sec.

>> implemented types splitting.
>
> This means that anonymous/non-linkage types are correctly kept in their original CUs?

yes. anonymous/non-linkage types are correctly kept in their original CUs.

> Does it mean other things too/instead? (splitting up types into chunks to avoid exceptionally large units containing all types?)

splitting up types into chunks is not implemented yet. I think it would take some time. I would prefer to implement it as an separate improvement for this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96035/new/

https://reviews.llvm.org/D96035