[PATCH] D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 10:55:57 PST 2022


MaskRay added a comment.

In D96035#3284832 <https://reviews.llvm.org/D96035#3284832>, @dblaikie wrote:

> In D96035#3284247 <https://reviews.llvm.org/D96035#3284247>, @avl wrote:
>
>> rebased.
>> refactored.
>> implemented performance improvements(it is 1.3x slower in single thread mode, 2.4x faster im multi-thread mode).
>
> 1.3x slower means what took 1second before now takes 2.3 seconds?

(https://randomascii.wordpress.com/2018/02/04/what-we-talk-about-when-we-talk-about-performance/ The ambiguity made me start to use "1.3x as fast" )

>> implemented types splitting.
>
> This means that anonymous/non-linkage types are correctly kept in their original CUs? Does it mean other things too/instead? (splitting up types into chunks to avoid exceptionally large units containing all types?)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96035/new/

https://reviews.llvm.org/D96035



More information about the llvm-commits mailing list