[PATCH] D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:201
-    getTargetStreamer()->emitTableType(Sym);
-    return;
   }
----------------
sbc100 wrote:
> Does removing this block not make this a functional change?  Are  there no tests that depend on `emitTableType` here?
Argh, I missed this. Actually this should be in D118122, in any case apparently we have no test which tests this execution path. I will commit with these lines and change D118122 to remove it instead, so this is truly a NFC. Well done noticing this detail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118121/new/

https://reviews.llvm.org/D118121