[PATCH] D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 28 09:56:34 PST 2022


sbc100 accepted this revision.
sbc100 added a comment.

LGTM % comment about emitTableType



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:201
-    getTargetStreamer()->emitTableType(Sym);
-    return;
   }
----------------
Does removing this block not make this a functional change?  Are  there no tests that depend on `emitTableType` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118121/new/

https://reviews.llvm.org/D118121



More information about the llvm-commits mailing list