[PATCH] D118460: [DebugInfo][InstrRef] Use a depth-first search to reduce the lifetime of tracking information

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Minor point, but:

> This patch is technically NFC, but I'm not putting NFC in the title because it shouldn't be considered a trivial change.

Generally I think it's still valuable to flag such a thing as NFC - it explains why there aren't any test changes and means someone can expect object files to be identical with/without the change (& if they aren't, that's a bug)

> I've kept the unordered-explore code available, and it can be selected with a command line flag, to ease debugging in the future. I might figure out a way to make the unit tests use both of these modes, but haven't done that yet.

That worries me a bit - leaving untested code in. Like `#if 0` but worse, because it is accessible, but untested. Would be good to either delete it (can be resurrected from source control) or test it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118460/new/

https://reviews.llvm.org/D118460