[PATCH] D118452: [polly][unittests] Link DeLICMTests with libLLVMCore

Fri Jan 28 05:49:30 PST 2022

ro added a comment.

In D118452#3279208 <https://reviews.llvm.org/D118452#3279208>, @Meinersbur wrote:

> DeLICMTests, like all the unittests indeed requires LLVMCore, but I would have assumed it is resolved as transitive dependency by cmake, or at least `llvm_config` inside `add_polly_unittest`.
>
> On Linux/x86_64, this configuration ist tested by https://lab.llvm.org/buildbot/#/builders/207 which does not show this issue. Are "implicit dependencies" something Solaris-specific?

This only happens on Solaris with `-DBUILD_SHARED_LIBS=ON`, which is `OFF` by default.  I guess this requirement is Solaris-specific, yes.  In a way, it makes sense: imagine the direct dependeny (which currently depends on `libLLVMCore`) drops that dependency in the future (not likely in this case, but well possible in general). Then the executable would suddenly fail to run, which cannot happen if you make the dependency explicit.

This instance is the only case of this problem in the whole tree (well, the parts I do build on Solaris).

================
Comment at: polly/unittests/DeLICM/CMakeLists.txt:1
+set(LLVM_LINK_COMPONENTS
+  Core
----------------
Meinersbur wrote:
> Before I accept the patch, could you add a comment saying why this is needed?
Sure, will do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118452/new/

https://reviews.llvm.org/D118452