[PATCH] D118452: [polly][unittests] Link DeLICMTests with libLLVMCore

Fri Jan 28 05:42:10 PST 2022

Meinersbur added a comment.

DeLICMTests, like all the unittests indeed requires LLVMCore, but I would have assumed it is resolved as transitive dependency by cmake, or at least `llvm_config` inside `add_polly_unittest`.

On Linux/x86_64, this configuration ist tested by https://lab.llvm.org/buildbot/#/builders/207 which does not show this issue. Are "implicit dependencies" something Solaris-specific?

================
Comment at: polly/unittests/DeLICM/CMakeLists.txt:1
+set(LLVM_LINK_COMPONENTS
+  Core
----------------
Before I accept the patch, could you add a comment saying why this is needed?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118452/new/

https://reviews.llvm.org/D118452