[PATCH] D118436: [flang] Initial lowering for empty program
Diana Picus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 28 04:30:25 PST 2022
rovka added a comment.
Ok, I went over the dead code too and I don't see anything obviously wrong with it. I guess we can come back to it as more cases get supported in future patches.
LGTM with the nits addressed. You should probably wait for someone else to have a look too, since I'm not very familiar with lowering.
================
Comment at: flang/lib/Lower/CallInterface.cpp:63
+//===----------------------------------------------------------------------===//
+// CallInterface implementation: this part is common to both caller and caller
+// sides.
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118436/new/
https://reviews.llvm.org/D118436
More information about the llvm-commits
mailing list