[PATCH] D118436: [flang] Initial lowering for empty program

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D118436#3278753 <https://reviews.llvm.org/D118436#3278753>, @rovka wrote:

> Yaay, it's great to see this patch! :) 
> I think it's a bit large though, maybe we can remove some things that aren't strictly necessary to make the test pass? That would make both this patch and future patches (where things are actually useed) easier to review.

It was discussed multiple time that the initial patch would be larger. We tried to trim it down and probably it could be a little bit smaller. As mentioned in the description, follow up patches will be smaller.



================
Comment at: flang/lib/Lower/Bridge.cpp:250
+  Fortran::lower::pft::Evaluation *evalPtr = nullptr;
+  Fortran::lower::SymMap localSymbols;
+  Fortran::parser::CharBlock currentPosition;
----------------
rovka wrote:
> Where is this used? I see some references to it, but it doesn't seem to be populated (or I could be just missing it, it's Friday). Maybe we can upstream the SymMap in a future patch, to make this easier to review?
SymMap was mostly present in the lowering directory. This patch moves it and makes some updates. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118436/new/

https://reviews.llvm.org/D118436