[PATCH] D118372: [SVE] Fix TypeSize->uint64_t implicit conversion in visitAlloca()

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 28 04:24:21 PST 2022


sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-alloca.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64 -mattr=+sve < %s | FileCheck %s
----------------
Hi @kmclaughlin, it seems there are some CHECK lines missing below, because the check for the condition has disappeared. Please don't remove any CHECK lines if you keep:
> ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
in the top of the file.

i.e. either don't keep this line, or don't manually edit the tests after generating.

In this case, I prefer to keep all context with all CHECK lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118372/new/

https://reviews.llvm.org/D118372



More information about the llvm-commits mailing list