[PATCH] D118398: [NVPTX] Remove fmin/fmax.NaN.f64 again

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

> Is it fine to leave the change in llvm/lib/Target/NVPTX/NVPTXInstrInfo.td as is?

I'd add a comment around `FMINNAN` that f64 variants do not actually exist. As long as we never lower to it it's not worth the trouble of refactoring tablegen to deal with a minor exception.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:575-577
     setFP16OperationAction(Op, MVT::f16, GetMinMaxAction(Expand), Expand);
     setOperationAction(Op, MVT::f32, GetMinMaxAction(Expand));
     setFP16OperationAction(Op, MVT::v2f16, GetMinMaxAction(Expand), Expand);
----------------
Shouldn't all these actions be `Legal`, given that we have instructions for them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118398/new/

https://reviews.llvm.org/D118398