[PATCH] D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1772
+maybeMoveCFI(MachineInstr &MI, MachineBasicBlock::iterator MaybeCFI) {
+  if (MaybeCFI->getOpcode() != TargetOpcode::CFI_INSTRUCTION ||
+      !(MI.getFlag(MachineInstr::FrameSetup) ||
----------------
chill wrote:
> efriedma wrote:
> > Maybe assert MI is an add or subtract, to make clear what cases you're expecting to handle here?
> There are already asserts like this at lines 1794-1795 (just a little below this comment), I think they ought to do.
It's more of a documentation this; I'm a little worried someone in the future will assume this helper is more general than it actually is.

Not a big deal either way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114547/new/

https://reviews.llvm.org/D114547