[PATCH] D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 09:57:40 PST 2022


chill marked an inline comment as done.
chill added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1772
+maybeMoveCFI(MachineInstr &MI, MachineBasicBlock::iterator MaybeCFI) {
+  if (MaybeCFI->getOpcode() != TargetOpcode::CFI_INSTRUCTION ||
+      !(MI.getFlag(MachineInstr::FrameSetup) ||
----------------
efriedma wrote:
> Maybe assert MI is an add or subtract, to make clear what cases you're expecting to handle here?
There are already asserts like this at lines 1794-1795 (just a little below this comment), I think they ought to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114547/new/

https://reviews.llvm.org/D114547



More information about the llvm-commits mailing list