[PATCH] D117620: AMDGPU/GlobalISel: Fix assert on invalid cond code for llvm.amdgcn.icmp

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1120
   if (Opcode == -1)
     return false;
 
----------------
foad wrote:
> Can you either put the new code here, or assert that getV_CMPOpcode succeeded here?
getV_CMPOpcode can still fail based on the type (although I guess illegal i16 compares should have failed the verifier already)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117620/new/

https://reviews.llvm.org/D117620