[PATCH] D117620: AMDGPU/GlobalISel: Fix assert on invalid cond code for llvm.amdgcn.icmp

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

> This reproduces the current behavior.

You mean SelectionDAG behaviour? I'm not a huge fan of reproducing weird corner case behaviour, but I guess this is OK.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1120
   if (Opcode == -1)
     return false;
 
----------------
Can you either put the new code here, or assert that getV_CMPOpcode succeeded here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117620/new/

https://reviews.llvm.org/D117620