[PATCH] D118222: [RISCV] Split f64 undef into two i32 undefs

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 03:01:13 PST 2022


frasercrmck added a comment.

Given that the description says "so that no store will be generated" I think it'd be helpful to pre-commit the test case so that this patch shows the improvement. I tested it locally and see:

  define double @func_return_double_undef() nounwind {
  ; RV32IFD-LABEL: func_return_double_undef:
  ; RV32IFD:       # %bb.0:
  ; RV32IFD-NEXT:    addi sp, sp, -16
  ; RV32IFD-NEXT:    fsd ft0, 8(sp)
  ; RV32IFD-NEXT:    lw a0, 8(sp)
  ; RV32IFD-NEXT:    lw a1, 12(sp)
  ; RV32IFD-NEXT:    addi sp, sp, 16
  ; RV32IFD-NEXT:    ret
    ret double undef
  }

Other than that LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118222/new/

https://reviews.llvm.org/D118222



More information about the llvm-commits mailing list