[PATCH] D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS

[Son Tuan Vu via Phabricator via llvm-commits]

tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:945
+  assert(STI->hasMOPS());
+  assert(STI->hasMTE() || Opcode != AArch64::MOPSMemorySetTaggingPseudo);
+
----------------
dmgreen wrote:
> I think this assert is still valid, isn't it?
No, please see Sjoerd's comment https://reviews.llvm.org/D117753#inline-1126864, backed by the specification https://github.com/ARM-software/acle/blob/next-release/main/acle.md#memcpy-family-of-memory-operations-standarization-instructions---mops


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-mops-mte.ll:13
+; GISel-O0-NEXT:    mov x8, xzr
+; GISel-O0-NEXT:    setgp [x0]!, x8!, x8
+; GISel-O0-NEXT:    setgm [x0]!, x8!, x8
----------------
dmgreen wrote:
> These instructions are invalid without MTE. The test should keep +mte
See reply above for removing `hasMTE` assertion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117763/new/

https://reviews.llvm.org/D117763