[PATCH] D118320: llvm-libunwind build fix for GCC on PPC32

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In the future, please include more context in the diff :)

https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface "To make reviews easier, please always include as much context as possible with your diff!"



================
Comment at: libunwind/include/__libunwind_config.h:58
 #  define _LIBUNWIND_HIGHEST_DWARF_REGISTER _LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC64
-# elif defined(__ppc__)
+# elif defined(__ppc__) || defined(__PPC__)
 #  define _LIBUNWIND_TARGET_PPC 1
----------------
Arfrever wrote:
> It would probably suffice:
> ```
> # elif defined(__powerpc__)
> ```
> Similarly in other places.
`__powerpc__` sounds good.

Both ppc32 and ppc64 define `__powerpc__` and `__PPC__`. Can you also check whether this works for powerpc32?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118320/new/

https://reviews.llvm.org/D118320