[PATCH] D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS

[Son Tuan Vu via Phabricator via llvm-commits]

tyb0807 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:3429
     return selectReduction(I, MRI);
+  case TargetOpcode::G_BZERO:
+  case TargetOpcode::G_MEMCPY:
----------------
dmgreen wrote:
> Why does this have a case for G_BZERO if selectMOPS asserts that opcode != G_BZERO?
Good point. Thanks for catching this. I'm also removing the assert, as there's no other way `expandMOPS` is gonna be called.


================
Comment at: llvm/unittests/Target/AArch64/InstSizes.cpp:25
 
-  return std::unique_ptr<LLVMTargetMachine>(static_cast<LLVMTargetMachine*>(
-      TheTarget->createTargetMachine(TT, CPU, FS, TargetOptions(), None, None,
-                                     CodeGenOpt::Default)));
+  return std::unique_ptr<LLVMTargetMachine>(
+      static_cast<LLVMTargetMachine *>(TheTarget->createTargetMachine(
----------------
dmgreen wrote:
> All of this seems unrelated?
This is the result of `clang-format -i`, I guess this is more correct than the older format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117763/new/

https://reviews.llvm.org/D117763