[PATCH] D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 07:34:02 PST 2022


DavidTruby added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15341
 
+static bool isCheapToExtend(const SDValue &N) {
+  unsigned OC = N->getOpcode();
----------------
paulwalker-arm wrote:
> Perhaps I'm being pedantic but do you mean "cheap" or do you mean "zero cost"?
I suppose I wasn't confident enough to declare that extending loads were definitely the same cost as normal loads :). Happy to change the name if you think isFreeToExtend would be better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118139/new/

https://reviews.llvm.org/D118139



More information about the llvm-commits mailing list