[PATCH] D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 07:07:55 PST 2022


peterwaller-arm accepted this revision.
peterwaller-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-masked-loads.ll:841
 
+define <8 x i64> @masked_load_sext_ugt_v8i32i64(<8 x i32>* %ap, <8 x i32>* %bp) #0 {
+; VBITS_GE_512-LABEL: masked_load_sext_ugt_v8i32i64:
----------------
Unimportant: Maybe worth a comment separator just above here to indicate that what follows is different. I rank this of low importance because the function name does cover it already.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-masked-loads.ll:868
+%ext = zext <8 x i32> %load to <8 x i64>
+ret <8 x i64> %ext
+}
----------------
Nit: differing indentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118139/new/

https://reviews.llvm.org/D118139



More information about the llvm-commits mailing list