[PATCH] D118132: [demangler] stricter NestedName parsing

[Nathan Sidwell via Phabricator via llvm-commits]

urnathan updated this revision to Diff 403255.
urnathan added a comment.

While I would probably agree about 'if () {... continue;}' if all those conditionals had different bodies, that;s not the case here.  All but one end with 'if (!SoFar) return; Subs.push_back(SoFar);'  I find it much easier to understand when that code is not duplicated.  The case were we don't push_back remains a continue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118132/new/

https://reviews.llvm.org/D118132

Files:
  libcxxabi/src/demangle/ItaniumDemangle.h
  libcxxabi/test/test_demangle.pass.cpp
  llvm/include/llvm/Demangle/ItaniumDemangle.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118132.403255.patch
Type: text/x-patch
Size: 14894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220126/9fbfeb54/attachment.bin>