[PATCH] D118132: [demangler] stricter NestedName parsing
Nathan Sidwell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 26 06:01:49 PST 2022
urnathan added inline comments.
================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:3173
if (State) State->ReferenceQualifier = FrefQualLValue;
- } else
+ } else {
if (State) State->ReferenceQualifier = FrefQualNone;
----------------
ChuanqiXu wrote:
> This change looks not necessary.
FWIW I've been informed that one must put braces on all the elses or none of them -- not a mixture. I dunno.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118132/new/
https://reviews.llvm.org/D118132
More information about the llvm-commits
mailing list