[PATCH] D118233: [MachineVerifier] Report allocatable classes for physical register copies

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 06:26:45 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetRegisterInfo.cpp:229-242
 TargetRegisterInfo::getMinimalPhysRegClassLLT(MCRegister reg, LLT Ty) const {
   assert(Register::isPhysicalRegister(reg) &&
          "reg must be a physical register");
 
   // Pick the most sub register class of the right type that contains
   // this physreg.
   const TargetRegisterClass *BestRC = nullptr;
----------------
This function was intended to follow along with the DAG version, which does not have the allocatable filter. It would probably be better to follow along with the pattern, and have the use have to explicitly filter with getAllocatableClass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118233/new/

https://reviews.llvm.org/D118233



More information about the llvm-commits mailing list