[PATCH] D117562: [AMDGPU] Sink immediate VGPR defs if high RP

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

This feels way too specific. Immediate defs aren't really a special case



================
Comment at: llvm/lib/Target/AMDGPU/GCNPreRAOptimizations.cpp:53-54
+
+  // Minimal real occupancy recorder for the function
+  unsigned MinOccupancy;
+
----------------
Isn't this already tracked in the MFI


================
Comment at: llvm/lib/Target/AMDGPU/GCNPreRAOptimizations.cpp:249
+  // For VGPR reg, check if we can sink a imm def to a use
+  else if (TRI->isVGPRClass(RC) && (!VGPRImmDef || !VGPRImmUse))
     return Changed;
----------------
No else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117562/new/

https://reviews.llvm.org/D117562