[PATCH] D117562: [AMDGPU] Sink immediate VGPR defs if high RP

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 04:33:16 PST 2022


vpykhtin added a comment.

In D117562#3272067 <https://reviews.llvm.org/D117562#3272067>, @foad wrote:

> Yes it is hard, but what alternative do we have? I think having the compiler make **a** decision about what occupancy it is trying to achieve, is better than not making any decision at all. And the scheduler already makes that decision, it is just not enforced.

I forgot how the scheduler currently works, I thought it just tries not to make the occupancy worse. I don't know how can we make an assumption for occupancy to enforce it. Given this task we could probably find how many sinks we can do and find out the achievable occupancy. This could also include not only loop sinks but any constants holding VGPRs throughout a function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117562/new/

https://reviews.llvm.org/D117562



More information about the llvm-commits mailing list